Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group actions - confirm dialog #1058

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

nidjo17
Copy link
Contributor

@nidjo17 nidjo17 commented Dec 30, 2022

Ability to define confirmation dialog for group actions. I think it's not currently supported.

@nidjo17 nidjo17 force-pushed the upd/group-action-confirmation branch from a275b7a to 64b5c0b Compare December 30, 2022 14:18
@nidjo17 nidjo17 changed the title group actions confirm dialog Group actions - confirm dialog Dec 30, 2022
@dakorpar
Copy link
Member

dakorpar commented Dec 30, 2022

@paveljanda @f3l1x anything against this? looks simple and useful

src/DataGrid.php Outdated Show resolved Hide resolved
@radimvaculik
Copy link
Member

@nidjo17 Hi, could you rebase your branch against next branch, please? I will review it and merge it. Thanks.

@nidjo17 nidjo17 force-pushed the upd/group-action-confirmation branch from f87b6ed to 1a2fa59 Compare January 27, 2023 19:50
@nidjo17
Copy link
Contributor Author

nidjo17 commented Jan 27, 2023

@nidjo17 Hi, could you rebase your branch against next branch, please? I will review it and merge it. Thanks.

Hi @radimvaculik it's rebased, thank you.

@radimvaculik radimvaculik changed the base branch from master to next January 27, 2023 20:03
src/DataGrid.php Outdated Show resolved Hide resolved
@nidjo17 nidjo17 force-pushed the upd/group-action-confirmation branch from f2ee32d to f4a98fe Compare January 27, 2023 20:44
@radimvaculik
Copy link
Member

@paveljanda Please, check it. Thanks.

@radimvaculik
Copy link
Member

@paveljanda Cloud you check this PR, please?

@paveljanda
Copy link
Member

I think @f3l1x will have to review that as since rewriting frontend script entirely, this will have to be included.

@radimvaculik
Copy link
Member

@f3l1x Ping.

@f3l1x
Copy link
Member

f3l1x commented May 9, 2023

I would wait for the next version of JS/CSS and implement it there.

@radimvaculik
Copy link
Member

@nidjo17 Could you rebase, please? Cc @lilianalillyy

@nidjo17 nidjo17 force-pushed the upd/group-action-confirmation branch from 2aa25b6 to 7443936 Compare September 20, 2023 12:47
@nidjo17 nidjo17 force-pushed the upd/group-action-confirmation branch from 7443936 to 1c36c3a Compare September 20, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants